[wp-trac] [WordPress Trac] #25023: WordPress 3.6 deleting data on custom post meta

[WordPress Trac]

#25023: WordPress 3.6 deleting data on custom post meta
-------------------------------------+--------------------
 Reporter:  cdwharton                |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  3.6.2
Component:  Administration           |     Version:  3.6
 Severity:  critical                 |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+--------------------

Comment (by nacin):

 After talking with SergeyBiryukov, jeremyfelt, johnbillion, atimmer, and
 simonwheatley (WordCamp Europe contributor day), it is time for this to be
 fixed.

 The global $post juggling is actually *not* the only problem. Even if you
 use $post_id from the save_post hook, update_post_meta() will take the
 revision ID and then choose to update the post ID again.

 Even someone who was checking DOING_AUTOSAVE and DOING_AJAX and using
 $post_id instead of global $post is affected. In our mind, that approaches
 and probably crosses the line of ignoring developer error versus a
 recognition that saving meta boxes is complicated and that this is a
 really bad bug if you catch it.

 [attachment:25023.2.diff] moves the upgrade to POST.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25023#comment:45>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software