[wp-trac] [WordPress Trac] #17077: Page parent li elements in nav menus not always given current-page-parent class

[WordPress Trac]

#17077: Page parent li elements in nav menus not always given current-page-parent
class
--------------------------+------------------------------
 Reporter:  andymacb      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Menus         |     Version:  3.1
 Severity:  minor         |  Resolution:
 Keywords:  needs-patch   |
--------------------------+------------------------------
Changes (by ruud@…):

 * cc: ruud@… (added)
 * keywords:  has-patch => needs-patch
 * component:  General => Menus
 * severity:  trivial => minor


Comment:

 OK, I looked into this way further together with @DH-Shredder and
 @Obenland today at the WCEU contributor day and this is what we found:

 - The initial problem is an effect of the menu not getting updated when a
 posttype relation is set or un-set.

 This latter point is relevant because with this patch only the adding of a
 posttype relation is represented OK in the menu, but un-setting a relation
 still reports a parent relation in the menu after un-setting it (if that
 makes sense).

 We concluded that getting rid of this bug, we should try to update any
 relevant menu's after setting or un-setting a posttype relation.

 The second half of the patch (setting the backwards compatible classes
 based on page-parent instead of menu-parent) is probabbly not a good
 solution, because the former underscore classes don't reflect the posttype
 relation, but the menu relation... so checking the menu relation makes
 sense.

 Thanks!

--
Ticket URL: <http://core.trac.wordpress.org/ticket/17077#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software