[wp-trac] [WordPress Trac] #24636: WP_User has no method to access WP_User->data
WordPress Trac
noreply at wordpress.org
Mon Oct 7 15:23:08 UTC 2013
#24636: WP_User has no method to access WP_User->data
--------------------------+------------------------------
Reporter: dd32 | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Users | Version: 3.5
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------------------
Comment (by barrykooij):
Talked this over with Nacin and my patch can be ignored/removed.
Although the {{{$data}}} property isn't private, it's not supposed to be
public either. The guideline Nacin uses at the moment is changing
properties that should be public to {{{public}}}, while leaving those that
should be private or protected at {{{var}}}. The {{{$data}}} property in
this case should be private, so creating a getter for it would give people
the idea that it should be used publicly.
I suggest closing the ticket, agree dd32?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/24636#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list