[wp-trac] [WordPress Trac] #24661: remove_accents is not removing combining accents

[WordPress Trac]

#24661: remove_accents is not removing combining accents
-----------------------------------------------+--------------------
 Reporter:  NumidWasNotAvailable               |       Owner:
     Type:  defect (bug)                       |      Status:  new
 Priority:  normal                             |   Milestone:  3.8
Component:  Formatting                         |     Version:  1.2.1
 Severity:  normal                             |  Resolution:
 Keywords:  has-patch needs-unit-tests commit  |
-----------------------------------------------+--------------------

Comment (by tar.gz):

 Today one of my German-speaking customers bumped into that problem, which
 motivated me to re-test the patch against the current beta
 (3.7-beta1-25639).

 I applied both [[attachment:22363.2.patch:ticket:22363]] (makes
 `remove_accents` run for `sanitize_file_name`), and
 [[attachment:24661.0.rev24527.patch]] (improves `remove_accents` by fixing
 combined characters).

 My findings are the same. To trigger the bug, I need to upload the
 customer's files via FF24/OSX. When uploading with Chrome or Safari, the
 browser seems to auto-convert the characters, while FF leaves them as
 combined characters. So it's an edge case, but within a population of
 95–100 million native German speakers, 40% of them running FF, it still
 occurs too frequently (not mentioning the French)...

 Before the patch:
 http://sandbox.4o4.ch/wp-git/?attachment_id=555
 '''Filename:''' Buttermödeli.jpg
 '''Result''': broken in Safari, working fine in FF/Chrome.

 After the patch, uploading the same image:
 http://sandbox.4o4.ch/wp-git/?attachment_id=557
 '''Filename:''' Buttermodeli.jpg
 '''Result:''' working fine everywhere, including Safari.

 Files follow in attachment.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24661#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software