[wp-trac] [WordPress Trac] #25317: Wrong guess in wp_guess_url() for symlinked install, or unit tests

[WordPress Trac]

#25317: Wrong guess in wp_guess_url() for symlinked install, or unit tests
------------------------------------+--------------------
 Reporter:  bpetty                  |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  3.7
Component:  Upgrade/Install         |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  needs-unit-tests close  |
------------------------------------+--------------------
Changes (by nacin):

 * keywords:  needs-unit-tests => needs-unit-tests close
 * priority:  highest omg bbq => normal
 * severity:  blocker => normal


Comment:

 Replying to [comment:8 dd32]:
 > It'd be nice to have a consistent way to unit test things that use
 `ABSPATH`, for example, for `WP_Filesystem` I had to override the
 `abspath()` method in the Mock FS handler to accept an optional path for
 `ABSPATH` for use during the tests.

 Usually mocking the class is exactly how testing would occur.

 Would $_ENV make more sense than $_SERVER? I'm not sure; just throwing it
 out there.

 I think we can safely close this as fixed, leaving needs-unit-tests of
 course. Am I correct that this is handled?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25317#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software