[wp-trac] [WordPress Trac] #10948: wp_list_comments() always assumes walker will echo.

[WordPress Trac]

#10948: wp_list_comments() always assumes walker will echo.
-------------------------+-----------------------------
 Reporter:  MikeLittle   |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Future Release
Component:  Comments     |     Version:  2.8.6
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------------
Changes (by nacin):

 * type:  defect (bug) => enhancement
 * milestone:  3.7 => Future Release


Comment:

 This looks pretty good.

 Rather than changing the signature of protected methods, what if we just
 moved the output buffering to outside of and around those method calls?
 Seems like it would be pretty clean and would prevent the need to touch
 those methods, which conveniently mirror existing custom callbacks
 otherwise.

 Only other thing, it appears there are some tabs-versus-spaces issues.

 Punting because you can always use an output buffer as a workaround for
 this, so this is low priority.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/10948#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software