[wp-trac] [WordPress Trac] #25464: Function no_items() returns only one result

[WordPress Trac]

#25464: Function no_items() returns only one result
--------------------------+-----------------------------
 Reporter:  pavelevap     |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  trunk
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 Function no_items() is called here:
 /wp-admin/includes/class-wp-list-table.php -> line 810
 But only when $this->has_items() returns false.

 And function no_items() is defined here:

 1) /wp-admin/includes/class-wp-ms-themes-list-table.php -> line 162
 There is no need for condition because only string "No themes found" will
 be shown everytime.

 2) /wp-admin/includes/class-wp-plugins-list-table.php -> line 167
 There is no need for condition because only string "You do not appear to
 have any plugins available at this time." will be shown everytime.

 I am not sure if we should only remove not used strings or make also other
 logic fixes.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25464>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software