[wp-trac] [WordPress Trac] #18200: Language Packs
WordPress Trac
noreply at wordpress.org
Tue Oct 1 07:02:26 UTC 2013
#18200: Language Packs
---------------------------------+-----------------------
Reporter: nacin | Owner: nacin
Type: task (blessed) | Status: accepted
Priority: normal | Milestone: 3.7
Component: Upgrade/Install | Version:
Severity: normal | Resolution:
Keywords: 3.7-early has-patch |
---------------------------------+-----------------------
Comment (by nacin):
Replying to [comment:74 Chouby]:
> In wp_get_installed_translations, the regex [A-Za-z_]{2,6} for detecting
the locale seems a bit restrictive. In my plugin dev, I encountered an
issue with this rule with German for which two languages packs are
distributed: de_DE as standard and de_DE_Sie for the formal language. See
http://wpde.org/download/sprachdateien/ . I am not aware of any other
exception.
As far as I can tell, this is extremely wrong. However, we could
potentially drop the `6` there, and just match anything. As long as they
are only using underscores as delimiters, we should be okay, as a domain
that matches a WP.org plugin or theme slug (and ideally any plugin or
theme) will always use hyphens.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/18200#comment:75>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list