[wp-trac] [WordPress Trac] #26315: Grunt: RTL & CSSMin Color schemes

WordPress Trac noreply at wordpress.org
Fri Nov 29 11:18:30 UTC 2013


#26315: Grunt: RTL & CSSMin Color schemes
--------------------------+------------------
 Reporter:  dd32          |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.8
Component:  Build Tools   |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------

Old description:

> Currently Colour schemes don't get RTL'd versions, which results in a
> very bland UI when using a non-default colour scheme.
>
> In addition, the colour schemes include `@import url("../../colors-
> fresh.css");` which needs to dynamically change to `.min.css`,
> `-rtl.css`, and, `-rtl.min.css`.

New description:

 Currently Colour schemes don't get RTL'd versions, which results in a very
 bland UI when using a non-default colour scheme in an RTL environment.

 In addition, the colour schemes include `@import url("../../colors-
 fresh.css");` which needs to dynamically change to `-rtl.css` so that
 minification includes the right file

--

Comment (by dd32):

 It looks like we'll need to add a `processContent`-like callback to the
 cssjanus grunt module to alter the include, or maybe a option to cssjanus
 to  RTL'ise all include filenames it runs into.

 I'm attaching my attempt at doing this, but it's not working. I'm not sure
 why, but `color-schemes/*/colors-rtl.min.css` appears to contain too much
 data, but `colors-rtl.css` and `colors.min.css` are fine.

 Obviously, the -rtl.min includes the .min instead of the RTL version still
 since I couldn't figure out a way to process the content without altering
 something other than the grunt file.

 I don't actually know what I'm doing with Grunt here.. so feel free to
 ignore the patch :)

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26315#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list