[wp-trac] [WordPress Trac] #26222: Remove superseded unit tests for balanceTags()
WordPress Trac
noreply at wordpress.org
Sun Nov 24 20:44:40 UTC 2013
#26222: Remove superseded unit tests for balanceTags()
-------------------------+-----------------------------
Reporter: coffee2code | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Unit Tests | Version:
Severity: minor | Keywords: has-patch
-------------------------+-----------------------------
Now that #1597 and #20401 have (long since) been committed, the unit tests
relating to `balanceTags()` can be updated to:
* Remove tests that existed solely to test the older, more limited tag
handling of the function. Tests already exist that supersede those,
testing the currently more comprehensive tag handling. Inline comments
confirm they can now be removed.
* Remove references to those now-closed tickets
FYI, I was the originator of all of the tests in
tests/formatting/balanceTags.php so these changes are in keeping with what
was originally planned when I wrote them.
Additionally, while I was in there I fixed the dataProvider function
`nestable_tags()` which wasn't providing the data properly. No harm since
it wasn't being used anyhow, but I went ahead and adapted one of the
existing tests to make use of it.
Patch attached.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/26222>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list