[wp-trac] [WordPress Trac] #25853: Changeset 25696 breaks expected value of argument sent to filter 'retrieve_password_message'

[WordPress Trac]

#25853: Changeset 25696 breaks expected value of argument sent to filter
'retrieve_password_message'
--------------------------+--------------------
 Reporter:  dcavins       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.7.2
Component:  Users         |     Version:  3.7
 Severity:  minor         |  Resolution:
 Keywords:                |
--------------------------+--------------------

Comment (by shawnhooper):

 I see a potential problem with this recommendation.  Changing $key to
 $hashed resolves the suggested use case of looking up user's information
 from the database (which stores the hashed activation key).

 However, any plugins that would use this filter to re-write the activation
 message need to include the key in plain-text for inclusion in the
 activation link.  Since the key cannot be obtained from the stored hash,
 it has to be passed to the filter from here.

 Recommend adding the hash as another parameter:

 {{{#!php
 $message = apply_filters( 'retrieve_password_message', $message, $key,
 $hashed );
 }}}

 so that anyone using this filter can make use of both the hashed and
 unhashed keys as needed.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25853#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software