[wp-trac] [WordPress Trac] #26099: Hook Docs: wp-admin/includes/user.php

[WordPress Trac]

#26099: Hook Docs: wp-admin/includes/user.php
---------------------------+---------------------------
 Reporter:  aaronholbrook  |       Owner:  DrewAPicture
     Type:  defect (bug)   |      Status:  reviewing
 Priority:  normal         |   Milestone:  3.8
Component:  Inline Docs    |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |
---------------------------+---------------------------
Changes (by DrewAPicture):

 * keywords:  has-patch => needs-patch
 * owner:   => DrewAPicture
 * status:  new => reviewing
 * milestone:  Awaiting Review => 3.8


Comment:

 Hi Aaron, thanks for the patch. Just a couple changes to make and we'll
 call this good:
 `editable_roles` filter:
 * If I'm not mistaken, the value of `$wp_roles->roles` property is an
 array, therefore `$all_roles` should be of the type array
 * Space out the `apply_filters` line per coding standards

 `get_users_drafts` filter:
 * The value of the `$query` parameter and the purpose of this filter is to
 literally filter the query string, e.g. `SELECT ID, post_title FROM
 wp_posts WHERE post_type = ...`. The filter and parameter descriptions
 should reflect that.
 * Space out the `apply_filters` line per coding standards

 `post_types_to_delete_with_user` filter
 * This filter was actually introduced in 3.4.0
 * The first parameter, `$post_types_to_delete`, is an array, not a string
 * The second parameter, `$id`, is missing from the doc block

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26099#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software