[wp-trac] [WordPress Trac] #25963: Appearance Themes: Backbone.Router should use pushState with ?query type urls

WordPress Trac noreply at wordpress.org
Mon Nov 18 22:38:14 UTC 2013


#25963: Appearance Themes: Backbone.Router should use pushState with ?query type
urls
-------------------------+--------------------
 Reporter:  matveb       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  3.8
Component:  Appearance   |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+--------------------

Comment (by adamsilverstein):

 Replying to [comment:5 carldanley]:
 > Let me know if you need something put together for this; would love to
 help!

 Your expertise & input appreciated! the original idea was to use query
 string urls like we currently use in revisions. I wasn't able to get it
 working without some kludgy code. The url would look like:

 {{{ wp-admin/themes.php?theme=[theme_name] }}}

 I believe the impetus was to match revisions and possibly provide a no-js
 fallback (since the theme name is passed to PHP this way). However,
 Backbone seems to be moving away from allowing/supporting query string
 routing. if we just enable pushState, we get URLS like this:

 {{{ wp-admin/themes.php/theme/[theme_name] }}}

 which is OK, perhaps a bit prettier would be something like

 {{{ wp-admin/themes/[theme_name] }}} which should require adding some
 logic to wp-admin/index.php

 you will also note a search route in the code, so far we've only talked
 about the theme route.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25963#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list