[wp-trac] [WordPress Trac] #25784: shortcode.js needs unit tests
WordPress Trac
noreply at wordpress.org
Mon Nov 18 17:19:37 UTC 2013
#25784: shortcode.js needs unit tests
-------------------------+--------------------
Reporter: iandunn | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.8
Component: Unit Tests | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------
Comment (by iandunn):
Replying to [comment:1 jorbin]:
> I cleaned the file up a bit based on our new jshnit standards (which
were added after your initial patch).
Awesome, thanks :)
> I also divided the assertions up a bit more. I think it's better to
have more tests with a few direct assertions than tests with a lot of
assertions. It makes it much easier to track down specific regressions.
Yeah, outside of Core I'm used to limiting each function to a single
assertion, but on another ticket Sergey
[http://core.trac.wordpress.org/ticket/23642#comment:13 recommended
grouping them]. I think I probably grouped them a bit too much, though, so
I like your version better.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25784#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list