[wp-trac] [WordPress Trac] #26086: Fix "moby6"
WordPress Trac
noreply at wordpress.org
Mon Nov 18 05:55:29 UTC 2013
#26086: Fix "moby6"
----------------------------+--------------------
Reporter: azaozz | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.8
Component: Administration | Version: trunk
Severity: normal | Resolution:
Keywords: ui-focus |
----------------------------+--------------------
Comment (by tollmanz):
@azaozz - I've started on some cleanup of this. After this comment, I will
attach a patch. I was waiting to upload this patch and start a ticket
until I got a member of the MP6 team to review it to make sure I am not
introducing regressions. While I can see a lot of JS issues with this
code, it is hard to change as it is difficult to grok what this code is
doing. That said, the forthcoming patch addresses the following:
* Removes {{{moby6}}} language
* Adds better selector caching
* Fixes the {{{stickymenu/stickyMenu}}} issues
* Adds underscore.js as a dependency for common.js in order to use the
{{{debounce}}} method
* Removes the {{{removeHamburgerButton}}} button, which was previously
missed
* Deprecates {{{matchMedia}}} as it appears unnecessary in this case
This gets the ball rolling, but obviously needs to address more of your
concerns. I would like to be able to have someone articulate what this
code is supposed to do, then improve it to do these things better.
Additionally, we need better documentation of these functions to better
describe its purpose. I think that is the toughest part of improving this
code.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/26086#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list