[wp-trac] [WordPress Trac] #25282: Unit Tests should run in Debug mode
WordPress Trac
noreply at wordpress.org
Fri Nov 15 06:32:07 UTC 2013
#25282: Unit Tests should run in Debug mode
----------------------------+---------------------
Reporter: wonderboymusic | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 3.7
Component: Unit Tests | Version: trunk
Severity: normal | Resolution: fixed
Keywords: |
----------------------------+---------------------
Comment (by bpetty):
That's a *really* specific job for `includes/utils.php` with
`_clean_term_filters()` there. There's a whole bunch of tests that are
leaving behind or removing hooks that they are supposed to reset at the
end of their tests like this, and we really shouldn't be just adding a ton
of really obscure and specific functions in a generic framework-wide
include like this.
Ideally, the test(s) responsible for leaving the hooks behind should be
removing them on teardown cleanup, or if this was just some default hooks
you needed removed specifically for these tests, then just remove them in
`setUp()`, and add them back in `tearDown()` (or in the specific test
itself). It should be clear about what those tests are doing within just
that file though.
P.S. This ticket is closed, and I'm not even sure what that last commit
has to do with this ticket at all anymore. Really need to start new
tickets for these now. Is this 5.5 debug errors now? These run fine with
debug in 5.4 and below.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25282#comment:80>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list