[wp-trac] [WordPress Trac] #26041: jshint shouldn't throw errors: wp-includes/js/plupload/handlers.js

[WordPress Trac]

#26041: jshint shouldn't throw errors: wp-includes/js/plupload/handlers.js
--------------------------+------------------------------
 Reporter:  mdbitz        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Build Tools   |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by mdbitz):

 Hi i've been reviewing the code however I have some questions on the
 remaining items identified by jshint.

 1) Should the following bind function be removed? or should it be wrapped
 in a jshint comment to ignore the error?

 {{{
 uploader.bind('BeforeUpload', function(up, file) {
     // something
 });
 }}}

 2) Should we remove parameters or add jshint ignore comments on items that
 are to-do items?

 {{{
 function deleteError(X, textStatus, errorThrown) {
         // TODO
 }
 }}}

 3) JShint is saying fileDialogStart and dndHelper are defined but not
 used. What is the correct metod to move ahead with clearing of these
 errors.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26041#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software