[wp-trac] [WordPress Trac] #25887: $comparison is unused in maintenance_nag()

[WordPress Trac]

#25887: $comparison is unused in maintenance_nag()
------------------------------+--------------------
 Reporter:  SergeyBiryukov    |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.7.2
Component:  Upgrade/Install   |     Version:  3.7
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+--------------------

Comment (by dd32):

 I think this might be the cause of Viper007Bond's issue in #14028
 actually.

 The nag is only supposed to show for $attempted == $wp_version when a
 critical failure occurs, currently it shows even when a non-critical error
 occurs (such as aborting early due to files not writable).

 The change appears correct.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25887#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software