[wp-trac] [WordPress Trac] #25858: Integrate MP6 into core

[WordPress Trac]

#25858: Integrate MP6 into core
----------------------------+------------------
 Reporter:  dd32            |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.8
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+------------------
Changes (by tollmanz):

 * cc: tollmanz@… (added)


Comment:

 25858.responsive.diff brings in the responsive component of MP6. The
 primary goal of this patch is to port this code to core, warts and all. We
 believe that this brings parity to the responsive component in MP6.

 In this process, we decided to make a few changes:

 * Removed jQuery mobile. This script was used to add swipe controls to
 open/close the sidebar menu. This feature was apparently buggy and due to
 the pending demise of jQuery mobile, it was removed.
 * Removed use of Backbone.js. Adding Backbone.js to this script would add
 a dependency of Backbone.js for all of the admin. Additionally, it was
 used to add a menu item. Instead of doing that, it was added via the admin
 menu API. This also fixes a bad delay in the item showing in the menu.

 While this patch ports the responsive component into core, there is much
 work to be done, including:

 * CSS code styling. A ton of CSS was dumped into wp-admin.css, but was not
 cleaned up. There is a lot of inconsistency with it and should be fixed
 up.
 * CSS organization. We should revisit if the CSS is in the proper place.
 It might make sense to reorganize it a bit now that this is core code.
 * Remove moby6 references. No need for this anymore.
 * jshinting. We should clean up JS to pass jshint tests.
 * Throttle resize event. We need to make sure these event don't hose
 performance.
 * Review use of matchMedia. I think that we could deprecate this and make
 it pure CSS.
 * Menu icon alignment in Chrome is a bit off and needs tweaked.
 * Sidebar quirkiness. On load in narrow view, it will initially pop out,
 then hide. There are lots of little quirks like this that need
 identification and fixing.
 * Overall review of code. There are likely other issues that need
 addressing and this code warrants a thorough review.

 Finally, I kept a log of changes we made to this patch. It gives the
 history of moving from the MP6 port to its current state. This history can
 be viewed here: https://gist.github.com/tollmanz/7442994/revisions. The
 following is a guide to these changes:

 1. Port of responsive component to core
 2. Removes jQuery mobile from patch
 3. Removes Backbone.js requirement from patch
 4. Styles the new menu icon
 5. Fixes a bug that hid the admin menu

 Props to iammattthomas, helen, dd32, and tollmanz for work on this.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25858#comment:29>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software