[wp-trac] [WordPress Trac] #25934: Spacebar does not toggle checkbox to open link in new window/tab when in distraction free writing mode
WordPress Trac
noreply at wordpress.org
Wed Nov 13 05:12:36 UTC 2013
#25934: Spacebar does not toggle checkbox to open link in new window/tab when in
distraction free writing mode
-----------------------------+-------------------------------------
Reporter: travisnorthcutt | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Editor | Version: 3.7.1
Severity: minor | Keywords: needs-testing has-patch
-----------------------------+-------------------------------------
To reproduce:
1. Edit a post
2. Enter distraction free writing mode
3. Select text
4. Click button to create a link (or press alt+shift+a)
5. Tab to focus the "Open link in a new window/tab" checkbox
6. Press the spacebar
7. Nothing happens
[[Image(https://dl.dropboxusercontent.com/s/drxdlxqiax61hca/2013-11-12%20at%2011.04%20PM.png)]]
This seems to have been introduced in
http://core.trac.wordpress.org/browser/trunk/wp-admin/js/wp-
fullscreen.dev.js?rev=18069, which is said to have fixed
http://core.trac.wordpress.org/ticket/17399, although the patch in
http://core.trac.wordpress.org/ticket/17399 did not introduce the code
that causes this. Regardless, the attached patch has been tested against
http://core.trac.wordpress.org/ticket/17399 and seems to introduce no
regressions. More testing welcome, though.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25934>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list