[wp-trac] [WordPress Trac] #25858: Integrate MP6 into core
WordPress Trac
noreply at wordpress.org
Wed Nov 13 04:07:36 UTC 2013
#25858: Integrate MP6 into core
----------------------------+------------------
Reporter: dd32 | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 3.8
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
----------------------------+------------------
Comment (by ryelle):
Replying to [comment:24 dd32]:
> More General:
> * What files were `src/wp-admin/css/color-schemes/_admin.scss` & `src
/wp-admin/css/color-schemes/_mixins.scss` based off? I'd rather do a `svn
cp` on the file so that we can see only the variables have been replaced,
and no rules were lost/added - I can see that'll be a messy diff due to
the mixin separation, but the declarations shouldn't change
Do you mean in the plugin? `components/color-schemes/schemes/_admin.scss`
& `components/color-schemes/schemes/_mixins.scss`.
> * Is there a reason why the colors.scss files appear to have duplicated
content (ie. double imports of colors-fresh.css, and the blue scheme
particularly)?
No, that was a mistake from my testing. Fixed in
[attachment:25858.colors.2.diff].
> * Probably best to add one colour scheme, and then `svn cp` the rest
(once again, to see whats different between them)
> * The `.dropdown` and `.expanded` styles are incredibly generic, can
they be prefixed with something specific to the job?
Changed the classes to `picker-dropdown`/`picker-expanded` in
[attachment:25858.colors.2.diff].
I also noticed that there are still `moby6` classes in `_admin.scss`,
those should be removed once we know what's up with the responsive
component.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25858#comment:27>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list