[wp-trac] [WordPress Trac] #25858: Integrate MP6 into core

[WordPress Trac]

#25858: Integrate MP6 into core
----------------------------+------------------
 Reporter:  dd32            |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.8
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+------------------

Comment (by dd32):

 > 25858.colors.diff​ merges in the colors component.

 > Add a new task to the Gruntfile: colors, which runs the Sass processing
 & CSS minification, and add this task to build. This does require ​Sass
 (and therefore Ruby) on the machine running grunt, specifically v 3.3.0 as
 we want to use the ​sourcemap option.

 * It's a shame we can't use libsass instead of using ruby sass, but as
 pointed out elsewhere, libsass isn't feature compatible yet, and doesn't
 support sourcemaps
 * @nacin can probably weigh in here a bit, but I'm wondering if perhaps we
 should commit the generated .css files from the scss files to /src/ ? I
 guess only having the base colour scheme defined is OK though, but, it's
 something that might be more useful in the future when other stylesheets
 are made with a pre-processor

 More General:
 * What files were `src/wp-admin/css/color-schemes/_admin.scss` & `src/wp-
 admin/css/color-schemes/_mixins.scss` based off? I'd rather do a `svn cp`
 on the file so that we can see only the variables have been replaced, and
 no rules were lost/added - I can see that'll be a messy diff due to the
 mixin separation, but the declarations shouldn't change
 * Is there a reason why the colors.scss files appear to have duplicated
 content (ie. double imports of colors-fresh.css, and the blue scheme
 particularly)?
 * Probably best to add one colour scheme, and then `svn cp` the rest (once
 again, to see whats different between them)
 * The `.dropdown` and `.expanded` styles are incredibly generic, can they
 be prefixed with something specific to the job?
 * (not specific to this patch) What's the job of `svg-painter.js`? It
 seems like it might only be used by the colour scheme picker? (Or does it
 actually do something on load too?) I ask since we're currently loading it
 on all pages

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25858#comment:24>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software