[wp-trac] [WordPress Trac] #24977: Workflow change: automate RTL css generation

WordPress Trac noreply at wordpress.org
Wed Nov 13 00:51:55 UTC 2013


#24977: Workflow change: automate RTL css generation
----------------------------+------------------
 Reporter:  yoavf           |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.8
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+------------------

Comment (by yoavf):

 Nacin in [http://irclogs.wordpress.org/chanlog.php?channel=wordpress-
 dev&day=2013-11-12&sort=desc#m726536 irc]:

 > so, next up would be untangling the .rtl stuff.
 > so, two groups of oddities.
 > one is files that janus wanted to add RTL bits to, but didn't have any
 RTL to begin with: buttons, jquery-ui-dialog, wp-auth-check
 > the other is ones that use .rtl - farbtastic, install, editor, wp-
 pointer
 > finally, colors-fresh uses some RTL, which I imagine should be pushed
 into wp-admin if at all possible (could specify border-color: instead of
 border-left-color:, assuming border-left-size: gets switched to border-
 right-size: in wp-admin.css, for example)

 '''wp-auth-check.css''' the generated RTL should be used.

 '''jquery-ui-dialog.css''' : most "flips" here should be skipped - but
 some are correct. All the ```.ui-resizable-xx``` should not be flipped,
 since they refer to the cursor changes at the various borders of the UI
 window. However, the ```float``` on ```.ui-dialog .ui-dialog-title```
 should be flipped. A few of the rules are overwritten with ```.rtl```
 calls in editor.css and need to be cleaned up there. I'll attach a patch
 for this file


 '''buttons.css''': There's one small minor rule that requires RTL
 ```margin-right: -1px;``` in ```.wp-core-ui .button-group > .button```.
 There's another one in ```.wp-core-ui input[type="reset"],[...]``` where
 we set both ```padding-right``` and ```padding-left``` separately but
 those can be combined.  Not sure about this one.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24977#comment:40>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list