[wp-trac] [WordPress Trac] #25858: Integrate MP6 into core

WordPress Trac noreply at wordpress.org
Wed Nov 13 00:47:42 UTC 2013


#25858: Integrate MP6 into core
----------------------------+------------------
 Reporter:  dd32            |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.8
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+------------------

Comment (by ryelle):

 [attachment:25858.colors.diff] merges in the colors component.

 * Add a folder to src/wp-admin/css with the Sass source files for color
 schemes.
 * Add a new task to the Gruntfile: `colors`, which runs the Sass
 processing & CSS minification, and add this task to `build`. This does
 require [http://sass-lang.com/ Sass] (and therefore Ruby) on the machine
 running grunt, specifically v 3.3.0 as we want to use the
 [https://npmjs.org/package/grunt-contrib-sass sourcemap] option.
 * Each processed color scheme generates a colors.css, colors.css.map, and
 colors.min.css in the build directory, along with keeping the colors.scss
 files.

 This also changes how color schemes are handled in core

 * There is a new property to each color scheme object, `icon_colors`. This
 is an array of colors used by svg-painter to match any SVG icons to the
 color scheme.
 * The color scheme picker has a new style & now auto-saves.

 **A few notes**
 * New function `set_color_scheme_json` creates the json object
 `mp6_color_scheme` used by svg-painter, and both should be renamed to
 something not MP6.
 * Color schemes won't work if you're running out of the src directory.
 Maybe we need to put some error handling there like (now) exists for RTL,
 if you're using a color scheme. And probably disable the color scheme
 picker.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25858#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list