[wp-trac] [WordPress Trac] #25549: Twenty Fourteen: implement featured content "tag" mechanism

[WordPress Trac]

#25549: Twenty Fourteen: implement featured content "tag" mechanism
---------------------------+--------------------
 Reporter:  lancewillett   |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  3.8
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+--------------------

Comment (by rachelbaker):

 Replying to [comment:39 lancewillett]:
 > Steps to repeat a few bugs with the Featured Content option in the
 Customizer.
 >
 > '''First bug'''
 >
 > Posts: set up your test install so that no posts are tagged "featured"
 and no sticky posts.
 >
 > 1. Open Customizer, open Featured Content pane.
 > 2. Tag name "featured" is in the input.
 > 3. Change the tag to something you do have tagged, with Unit Test sample
 data "Post Formats" works.
 > 4. Save in Customizer (notice here it doesn't refresh the Customizer
 iframe version of the site -- that's bug 2 below)
 > 5. Go to front end, refresh. The posts show up as expected in Featured
 Content area.
 > 6. Open Customizer again, in Featured Content pane clear out the tag and
 save.
 > 7. Go to front end, refresh. Post Formats posts are still in Featured
 Content area! Should be empty instead.

 Found that when the text field for the Featured Content setting tag_name
 was emptied, the logic in the settings callback method validate_settings()
 was not clearing the tag_id.  Updated the settings processing logic for
 the tag_name and tag_id settings in
 [http://core.trac.wordpress.org/attachment/ticket/25549/25549.bug1.patch
 25549.bug1.patch]

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25549#comment:40>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software