[wp-trac] [WordPress Trac] #25187: .jshintrc & .jshintignore support

WordPress Trac noreply at wordpress.org
Thu Nov 7 04:00:28 UTC 2013


#25187: .jshintrc & .jshintignore support
----------------------------------------+------------------------------
 Reporter:  carldanley                  |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  General                     |     Version:  trunk
 Severity:  normal                      |  Resolution:
 Keywords:  dev-feedback needs-testing  |
----------------------------------------+------------------------------

Comment (by tollmanz):

 I just audited the JS files in WordPress in order to prepare a list of
 files that we need to cleanup in order for jshint to pass. In this
 process, I found that a number of files that are WordPress code, not 3rd
 party code, are buried in the "3rd-Party Scripts" excludes. These all need
 to be added to the jshint task:


 {{{
 # Could not be positively identified as 3rd party
 wp-includes/js/jquery/jquery.table-hotkeys.js

 # WP specific tinyMCE plugins
 wp-includes/js/tinymce/plugins/wordpress/editor_plugin_src.js
 wp-includes/js/tinymce/plugins/wpdialogs/editor_plugin_src.js
 wp-includes/js/tinymce/plugins/wpdialogs/js/popup.js
 wp-includes/js/tinymce/plugins/wpdialogs/js/wpdialog.js
 wp-includes/js/tinymce/plugins/wpeditimage/editor_plugin_src.js
 wp-includes/js/tinymce/plugins/wpeditimage/js/editimage.js
 wp-includes/js/tinymce/plugins/wpfullscreen/editor_plugin_src.js
 wp-includes/js/tinymce/plugins/wpgallery/editor_plugin_src.js
 wp-includes/js/tinymce/plugins/wplink/editor_plugin_src.js
 wp-includes/js/tinymce/plugins/wpview/editor_plugin_src.js

 # Other
 wp-includes/js/tinymce/wp-tinymce-schema.js
 wp-includes/js/mediaelement/wp-mediaelement.js
 wp-includes/js/plupload/wp-plupload.js
 }}}

 A thorough accounting of jshint status can be found here:
 https://gist.github.com/tollmanz/7348654. @kadamwhite should be posting
 this to a Make blog tomorrow.

 I found that reinstating these individual files after the directories have
 been excluded works the charm for getting them jshinted. If there is a
 better way to do this, I am all ears.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25187#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list