[wp-trac] [WordPress Trac] #25662: Hook Docs: wp-admin/includes/class-wp-comments-list-table.php
WordPress Trac
noreply at wordpress.org
Tue Nov 5 01:19:12 UTC 2013
#25662: Hook Docs: wp-admin/includes/class-wp-comments-list-table.php
--------------------------+------------------------
Reporter: siobhyb | Owner: kpdesign
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 3.8
Component: Inline Docs | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------------
Comment (by kpdesign):
@siobhyb: Thanks for updating the patch. :)
Just a few small things to fix:
I noticed you edited lines 314-315, but there's no filter there. Could you
remove that edit please?
`comments_per_page`:
- Remove extra whitespace at the end of each line in the doc block.
`comment_status_links`:
- Remove extra whitespace at the end of the first @param line.
`comment_edit_pre`:
- Remove `<?php echo` after opening `<textarea class=...>` tag (same
line).
- Change `esc_textarea( apply_filters( 'comment_edit_pre',
$comment->comment_content ) ); ` to `echo esc_textarea( apply_filters(
'comment_edit_pre', $comment->comment_content ) );`.
It should look like this:
{{{
<textarea class="comment" rows="1" cols="1">
<?php
/** This filter is documented in wp-
admin/includes/comment.php */
echo esc_textarea( apply_filters( 'comment_edit_pre',
$comment->comment_content ) );
?>
</textarea>
}}}
`manage_comments_custom_column`:
- Second @param line, only one space between the $var and the description,
then align the description on the first @param line to match the
description on the second line.
> Can you let me know if I've done this correctly this time? Thanks. :)
Yes, you did. The latest patch is from the root directory. :)
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25662#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list