[wp-trac] [WordPress Trac] #25819: "ms_files_rewriting" site option is not created during upgrades

[WordPress Trac]

#25819: "ms_files_rewriting" site option is not created during upgrades
-----------------------------+-----------------------------
 Reporter:  gradyetc         |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:  3.5
 Severity:  minor            |   Keywords:
-----------------------------+-----------------------------
 While testing an upgrade for a MU era multisite install from 3.1.4 ->
 3.6.1 I discovered that the "ms_files_rewriting" site option was not being
 created.

 The attempt in `upgrade_network()`...

 {{{
 if ( $wp_current_db_version < 21823 )
         update_site_option( 'ms_files_rewriting', '1' );
 }
 }}}

 ... is failing.  I believe this has gone unnoticed since the default value
 is forced to `true` in wp-includes/ms-default-filters.php:

 {{{
 // If the network upgrade hasn't run yet, assume ms-files.php rewriting is
 used.
 add_filter( 'default_site_option_ms_files_rewriting', '__return_true' );
 }}}

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25819>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software