[wp-trac] [WordPress Trac] #24346: Revisions reloading all comparisons in two handle mode instead of just available comparisons

[WordPress Trac]

#24346: Revisions reloading all comparisons in two handle mode instead of just
available comparisons
-----------------------------+--------------------
 Reporter:  adamsilverstein  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  3.6
Component:  Revisions        |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+--------------------

Comment (by adamsilverstein):

 Replying to [comment:10 ocean90]:
 > Can you remove the parentheses from lines like `Diff.leftDiffStart = (
 isRtl ? ui.values[1] : ui.values[0] );`?
 >
 > Maybe change also `! isRtl ? $( '#next' ) : $( '#previous' )` to `isRtl
 ? $( '#previous' ) : $( '#next' )`.

 like the 2nd suggestion better - i will do that; added parentheses because
 original code was ambiguous and actually wasn't doing what you would
 expect;

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24346#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software