[wp-trac] [WordPress Trac] #24346: Revisions reloading all comparisons in two handle mode instead of just available comparisons

WordPress Trac noreply at wordpress.org
Thu May 16 22:08:12 UTC 2013


#24346: Revisions reloading all comparisons in two handle mode instead of just
available comparisons
-----------------------------+--------------------
 Reporter:  adamsilverstein  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  3.6
Component:  Revisions        |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+--------------------

Comment (by adamsilverstein):

 in [attachment:24346.3.diff​ 24346.3.diff​]:
 * load scopeOfChanges from other handle for tick marks that handle can
 reach in two handle mode when reloading models, now all ticks have a scope
 of changes
 * corrects missing parentheses bug introduced by rtl code causing l/r
 models to always reload- reload shouldn't happen if handle starts and
 stops in the same spot - nothing has changed.
 * added parentheses in several other places where isRtl trinary operator
 could be misinterpreted
 * removed delay/setTimeout functionality - just adding overhead/complexity
 - browsers already queue/limit simultaneous requests, timeout was just a
 guess anyway

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24346#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list