[wp-trac] [WordPress Trac] #24076: Uploading .mov file results in a big grey box
WordPress Trac
noreply at wordpress.org
Wed May 15 17:46:34 UTC 2013
#24076: Uploading .mov file results in a big grey box
--------------------------+--------------------
Reporter: ocean90 | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.6
Component: Media | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch |
--------------------------+--------------------
Comment (by kovshenin):
Looked into this a little more and there are several issues that need to
be addressed.
First is code duplication between post-formats.js and media-editor.js
where we convert a chosen video to a shortcode. It seems like we can
simply use `wp.media.editor.send.attachment` in post-formats.js which will
take into account supported types in media-editor.js and produce the
correct HTML code for the output. However, `mediaPreview` in that respect
is slightly different since it does not operate on a shortcode, but rather
renders a video from the attachment model.
Second is the whole UX flow of supported and unsupported media formats.
During a `mediaPreview` with an attachment model, we can find out whether
the file type is supported and render an error message if not. However,
that only works during the video selection flow, so as soon as you save
the post and cause a refresh, the preview will just render whatever HTML
is in the PF meta, which is weird, especially since the preview area is
not clearly marked as a preview area.
Finally, I think the HTML area is too permissive. We know we're expecting
a video, but we're really accepting arbitrary HTML. I'm trying to think of
a way we can restrict it to supported media only, including all possible
video shortcodes, oEmbed, etc. Any ideas?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/24076#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list