[wp-trac] [WordPress Trac] #24327: 'Add Media' button should show for all formats if Post Formats UI is disabled
WordPress Trac
noreply at wordpress.org
Tue May 14 20:03:12 UTC 2013
#24327: 'Add Media' button should show for all formats if Post Formats UI is
disabled
--------------------------------------+--------------------
Reporter: DrewAPicture | Owner:
Type: defect (bug) | Status: new
Priority: high | Milestone: 3.6
Component: Post Formats | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch dev-feedback |
--------------------------------------+--------------------
Comment (by azaozz):
Currently the show/hide UI checkbox toggles a class in two different
places that affect only some elements on the screen. Thinking we should
toggle a class on the body so we can properly reset the screen when the
post formats UI is hidden.
Also currently we have two code blocks that check whether post formats are
supported/enabled: in [http://core.trac.wordpress.org/browser/trunk/wp-
admin/admin-header.php#L88 admin-header.php] and
[http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-
advanced.php#L129 edit-form-advanced.php] (the part in the second code
block is not needed).
We can easily move the check whether to show the UI
([http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-
advanced.php#L147 $user_wants = get_user_option...]) in admin-header,
allowing us to toggle a class on the body.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/24327#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list