[wp-trac] [WordPress Trac] #23550: Twenty Thirteen: add RTL support

[WordPress Trac]

#23550: Twenty Thirteen: add RTL support
---------------------------+---------------------
 Reporter:  lancewillett   |       Owner:
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:  3.6
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:  fixed
 Keywords:                 |
---------------------------+---------------------

Comment (by maor):

 Hey y'all! It's been a while...

 I went over the theme again this weekend and was only able to find 2 RTL
 issues. Both are minor.

 Let me explain a bit about [attachment: 23550.5.diff].

 Both fixes have to do with the pagination arrows that are showing up on
 attachment pages and on single posts. The thing is that the direction of
 the arrows should be flipped on RTL sites, otherwise it'll look quite
 weird (imagine this - http://note.io/10NbNym).

 This is how the single post view looks with the patch applied. Notice that
 the links have been flipped to match the RTL "visual language"
 http://note.io/10CVgmj

 There is the `$text` parmeter that is being passed on to all of these
 functions (`previous_post_link`, `next_post_link`, `previous_image_link`
 and `next_image_link`). There was one case where I couldn't use
 `sprintf()` to place the proper arrow direction because of some text that
 looks like a sprintf tag (Where it says `%title` -- `'<span class="meta-
 nav">←</span> %title'`). So instead I used a `if ( is_rtl() ) : ...
 else : ... endif;` conditional.

 There might be a better way to do it. I'd like to hear what you guys think
 about it. If I wasn't clear enough, I can try explaining it again.

 Cheers!

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23550#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software