[wp-trac] [WordPress Trac] #24278: Quotes Invalid/Inconsistent on Attributes within general-template.php

[WordPress Trac]

#24278: Quotes Invalid/Inconsistent on Attributes within general-template.php
--------------------------+------------------------------
 Reporter:  sterlo        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Formatting    |     Version:  3.5.1
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------
Description changed by SergeyBiryukov:

Old description:

> The file I'm speaking of:
> https://github.com/WordPress/WordPress/blob/master/wp-includes/general-
> template.php
>
> Story: I was trying to take paginate_links() and customize the markup by
> running regular expressions  and pulling out the classes and values and
> such. The regular expressions weren't working...because the markup was
> incorrectly and inconsistently using single quotes for attributes instead
> of double quotes.
>
> I saw that, looked throughout the file, found more offenses.
>
> Here's a list:
> * get_archives_link()
> * wp_no_robots()
> * paginate_links()
> * wp_admin_css()
>
> and I'm not sure, but it also looks like __checked_selected_helper() is
> offending.
>
> I'll be attaching patches for this.

New description:

 The file I'm speaking of:
 https://github.com/WordPress/WordPress/blob/master/wp-includes/general-
 template.php

 Story: I was trying to take paginate_links() and customize the markup by
 running regular expressions  and pulling out the classes and values and
 such. The regular expressions weren't working...because the markup was
 incorrectly and inconsistently using single quotes for attributes instead
 of double quotes.

 I saw that, looked throughout the file, found more offenses.

 Here's a list:
 * get_archives_link()
 * wp_no_robots()
 * paginate_links()
 * wp_admin_css()

 and I'm not sure, but it also looks like `__checked_selected_helper()` is
 offending.

 I'll be attaching patches for this.

--

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24278#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software