[wp-trac] [WordPress Trac] #24210: Issues found using a static analysis tool

[WordPress Trac]

#24210: Issues found using a static analysis tool
--------------------------+-----------------------
 Reporter:  rlerdorf      |       Owner:  nacin
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  3.6
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+-----------------------

Comment (by nacin):

 In [changeset:"24189"]:
 {{{
 #!CommitTicketReference repository="" revision="24189"
 Fix usage of undeclared variables.
  * the_weekday_date() needs the global $currentday
  * ms_site_check() needs the global $current_site
  * media list table does not need to check for $total_orphans
  * upgrader has no $feedback variable, appears to be copypasta from other
 upgrade APIs
  * install_themes_feature_list() has no $features variable, return array()
 instead of a new return type of WP_Error

 see #24210.
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24210#comment:34>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software