[wp-trac] [WordPress Trac] #24258: PHP notices throws when the attachment parent not exists

[WordPress Trac]

#24258: PHP notices throws when the attachment parent not exists
------------------------------------+------------------------------
 Reporter:  alex-ye                 |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Media                   |     Version:  3.5.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------------
Changes (by adamsilverstein):

 * keywords:  has-patch => has-patch dev-feedback


Comment:

 Replying to [comment:1 alex-ye]:

 thank you for contributing the bug report _and_ a patch! bravo!

 a few notes:

 * its best to generate your patches from wp root, this makes applying
 easier
 * you can combine all your file updates into a single patch (same reason)
 * watch out for spaces vs. tabs, you might want to turn these on visually
 in your editor; your patch files had many lines indented with spaces -
 check the [http://make.wordpress.org/core/handbook/coding-standards/php
 php coding standards]

 [attachment:24258.diff​ 24258.diff​] refactors your patches and is
 generated from the root, also cleans up spaces vs. tabs issue and a little
 OCD space cleanup on the get_attachment_link since we were in there anyway
 (although you don't usually need to clean up old code that isn't to
 standard)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24258#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software