[wp-trac] [WordPress Trac] #24254: Big images break side-by-side revision viewer + inconsistency when displaying images

WordPress Trac noreply at wordpress.org
Fri May 3 23:30:49 UTC 2013


#24254: Big images break side-by-side revision viewer + inconsistency when
displaying images
--------------------------+--------------------
 Reporter:  a.hoereth     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.6
Component:  Revisions     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by adamsilverstein):

 Replying to [comment:5 a.hoereth]:
 > I get your point and also think that the wp_kses_post is more useful
 from an user point of view.
 > Still to notice: a new revision is saved when editing the image source
 code. You won't see any difference between the revisions using
 wp_kses_post.
 >
 > What about shortcodes in revision view? [caption] for example.
 >

 i tried [attachment:24254-2.patch 24254-2.patch] but it just let the image
 get as wide as the html said and i got a big horizontal scroll bar on
 large images i inserted in my testing; ( see http://cl.ly/OjVO )

 actually, i don't think we can really safely resize the images might have
 unintended side effects, plus what if a user inserts several small images
 in a row?

 what about setting max-width on the containing td's and setting their
 overflow to hidden or scroll? i think that should enforce a neat layout
 regardless of content. we should really get away from tables entirely, but
 thats for another day.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24254#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list