[wp-trac] [WordPress Trac] #24184: Twenty Thirteen: remove fixed navbar

[WordPress Trac]

#24184: Twenty Thirteen: remove fixed navbar
---------------------------+------------------
 Reporter:  lancewillett   |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  3.6
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------

Comment (by nacin):

 Good points here. I'm still a pretty strong no.

 This is not just the newest default theme for WordPress. This is a theme
 that hundreds of thousands of people are going to open up and tear apart.
 If the original developers involved in putting Kubrick together knew most
 of us would have learned WordPress theming through it, do you think they
 would have done X, Y, and Z differently?

 A default theme should be elegant. Not just in design, but in code. It
 needs to be simple. Too clever is cool on occasion, and is often just fine
 when it is buried in some internals. Too clever is not cool when people
 '''who are not programmers''' are going to be dissecting this theme and
 those who are programmers using it as a '''baseline''' for the next 12-24
 months.

 The standard we hold a default theme should be unique. It is most
 certainly more constraining — by its necessity as a standard-bearer and as
 a learning tool. It's because it sets a particular bar: "''this'' is how
 you code a theme." And yet, despite those constraints, we have a pretty
 great, bold design here.

 This theme makes more than enough of a statement when it comes to design.
 Does it ''really'', ''honestly'' need this too? Twenty Thirteen is nearly
 2,000 lines of PHP. That is a good chunk of code. (Also 5,000 lines of
 CSS.) We're now talking specifically about 126 lines of not uncomplicated
 JavaScript, and for what? This is not amazing, nor is it must-have. This
 is scroll-to-top, some nifty fixed positioning, and what really just looks
 like a lot of code cruft and an over-the-top bell/whistle we couldn't part
 with because reasons.

 (Side note: if we bundled vanilla masonry (http://vanilla-
 masonry.desandro.com/), we could get rid of the jQuery dependency all
 together.)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24184#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software