[wp-trac] [WordPress Trac] #23935: Revision UI cleanup / improvements / corrections

[WordPress Trac]

#23935: Revision UI cleanup / improvements / corrections
-----------------------------+--------------------
 Reporter:  adamsilverstein  |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  3.6
Component:  Revisions        |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |
-----------------------------+--------------------

Comment (by adamsilverstein):

 Replying to [comment:25 ocean90]:
 > [attachment: 23935-improved-tick-marks.7.diff]:
 >
 > * Adds tooltip background color to classic style
 > * Adds for the first and the last tick border-radius 3px since the
 slider has it too. Otherwise it will overlap the slider

 good catch

 > * I have increased the width of the ticks by 1px. `scope-of-changes-
 none` has 1px, `scope-of-changes-vsmall` has 2px and so on.
 >

 great.


 > Issues:
 >
 > * Because we have now `scope-of-changes-none` with 1px which will be
 extended to 2px+ we should remove the style declarations for `completed-
 false` and `completed-true` since it's not visible anymore and the width
 increase seems good enough for a loading animation. But we can leave the
 classes.

 the 'completed' class adds an animation to the tick mark while the
 underlying revision diff is loaded, don't think changing width really
 works as well may be enough though.

 > * In single mode the last tick gets always the `.scope-of-changes-none`
 class

 this is usually the 'current' revision, is the scope still 'none' even if
 there are several changes in the current version? if so this is a bug and
 i will dig deeper.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23935#comment:26>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software