[wp-trac] [WordPress Trac] #24184: Twenty Thirteen: remove fixed navbar

[WordPress Trac]

#24184: Twenty Thirteen: remove fixed navbar
---------------------------+------------------
 Reporter:  lancewillett   |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  3.6
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------

Comment (by obenland):

 I'm sad the IRC decision went in the direction it did.

 There were three arguments I could make out in the discussion log for
 removing it:

 * It's not super useful
 * When you're logged in or have a logged-out toolbar, you get double bar'd
 * It disables the CSS for the toolbar

 [[BR]]

 ==  It's not super useful
 Starting a theme process with design, removes the argument that everything
 about that theme needs to be functional. The fixed navbar is one of the
 immediately noticeable features that set Twenty Thirteen apart from other
 themes. It is a visual design element and originally was not meant to
 serve a specific functional purpose. Nevertheless, with the home link, the
 search form, and the scroll-to-top functionality, we went out of our way
 to make the fixed navbar more than just the design element it was intended
 to be.

 == When you're logged in or have a logged-out toolbar, you get double
 bar'd
 The argument of duplicate functionality with the admin toolbar leaves out
 the vast majority of visitors, that are not logged in when viewing a site.
 And mobile users, who will never see a fixed navbar.

 If that wasn't persuasive enough, we can still make it dependent on
 `is_admin_bar_showing()` if the additional 28px are really that bad.

 == It disables the CSS for the toolbar
 We removed the code disabling the toolbar callback in r24036, and
 significantly improved the performance of the scroll event callback in
 r24005.

 [[BR]]

 The loss of code is marginal really, compared to other parts of the theme,
 like the right sidebar. And IMO it doesn't justify the loss of identity
 that goes with removing it.

 I love the improvements Twenty Thirteen saw over the last two and a half
 months, especially the short (and I believe not yet finished)
 `functions.php` walk trough with Nacin. But I feel that some recent
 tickets and changes weren't really improvements, but rather steps back.
 Like removing the navbar would be.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24184#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software