[wp-trac] [WordPress Trac] #23503: Post Formats: i18n issues (was: Standard post format needs more contexts)
WordPress Trac
noreply at wordpress.org
Sun Mar 31 21:34:00 UTC 2013
#23503: Post Formats: i18n issues
----------------------------+--------------------
Reporter: SergeyBiryukov | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.6
Component: I18N | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch |
----------------------------+--------------------
Changes (by SergeyBiryukov):
* keywords: has-patch => needs-patch
Old description:
> 1. Most of the time, we refer to the "Standard" post format with the
> appropriate context: [[BR]]
> http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes
> /class-wp-posts-list-table.php#L1013 [[BR]]
> http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/press-
> this.php#L480 [[BR]]
> http://core.trac.wordpress.org/browser/tags/3.5.1/wp-
> includes/post.php#L5325
>
> In a couple of places, however, the context is missing: [[BR]]
> http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes
> /meta-boxes.php#L318 [[BR]]
> http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/options-
> writing.php#L90
>
> 2. [23449] introduced Edit screen UI for post formats. There's now a
> "Standard" tab above the post title. In Russian, "post" is feminine and
> "format" is masculine, so seeing "Standard" adjective without the
> "format" word next to it is confusing. I guess the tab needs a separate
> context.
New description:
1. Most of the time, we refer to the "Standard" post format with the
appropriate context: [[BR]]
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes
/class-wp-posts-list-table.php#L1013 [[BR]]
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/press-
this.php#L480 [[BR]]
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-
includes/post.php#L5325
In a couple of places, however, the context is missing: [[BR]]
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/meta-
boxes.php#L318 [[BR]]
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/options-
writing.php#L90
2. ~~[23449] introduced Edit screen UI for post formats. There's now a
"Standard" tab above the post title. In Russian, "post" is feminine and
"format" is masculine, so seeing "Standard" adjective without the "format"
word next to it is confusing. I guess the tab needs a separate context.~~
Fixed in [23843].
3. [23843] introduced a couple of issues:
1. `ucfirst( sprintf( __( '%s Post' ), $slug ) )`: [[BR]]
http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-
advanced.php?rev=23868#L186
1. `'%s Post'` is not localizable, see [comment:ticket:17609:3 dd32's
comment] in #17609.
2. `ucfirst()` doesn't always work correctly for UTF-8 characters, it
depends on PHP locale.
We should use actual labels instead of just putting post format slugs
into a generic string.
1. i18n is missing in line 397: [[BR]]
http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-
advanced.php?rev=23868#L397
--
--
Ticket URL: <http://core.trac.wordpress.org/ticket/23503#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list