[wp-trac] [WordPress Trac] #16215: Post Revision history displays the incorrect author

[WordPress Trac]

#16215: Post Revision history displays the incorrect author
-------------------------------------+-----------------------
 Reporter:  mdawaffe                 |       Owner:  westi
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  3.6
Component:  Revisions                |     Version:  2.6
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |
-------------------------------------+-----------------------

Comment (by adamsilverstein):

 Replying to [comment:73 azaozz]:
 > As far as I can see the above tests fail because they don't expect the
 extra revision added after saving the post.
 >
 > Moving from `'pre_post_update'` to `'post_updated'` is a big change and
 there would probably be more bugs and inconsistencies. This also creates a
 copy of the post when it may not be needed, like publishing from
 QuickPress and PressThis and updating a post programmatically.
 >
 > Another inconsistency: for some reason the `guid` for revisions is a
 permalink (instead of ?p=123 like drafts). That makes all revisions for a
 post have the same `guid`: 123-revision-v1.

 i agree, moving from saving revisions from pre to post update is a big
 change. i specifically asked nacin about this in IRC and the answer was
 essentially, 'now is the time'.

 a current revision is needed when you want to add information to the
 current revision - whats currently stored in the db - as it is, you can't
 do this until the post is updated, because you don't have a revision yet.
 in addition, the old pre_ system introduced the bug we are correcting -
 old post data was saved ('authored') by the current user, hence authors
 off by one.

 the current package of fixes brings the old data up to date (once), and
 starts keeps current revisions. plugin authors will have to adapt, but
 will hopefully cheer the new current revision.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16215#comment:74>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software