[wp-trac] [WordPress Trac] #16215: Post Revision history displays the incorrect author

WordPress Trac noreply at wordpress.org
Mon Mar 25 23:46:29 UTC 2013


#16215: Post Revision history displays the incorrect author
--------------------------------------------------+-----------------------
 Reporter:  mdawaffe                              |       Owner:  westi
     Type:  defect (bug)                          |      Status:  accepted
 Priority:  normal                                |   Milestone:  3.6
Component:  Revisions                             |     Version:  2.6
 Severity:  normal                                |  Resolution:
 Keywords:  dev-feedback needs-testing has-patch  |
--------------------------------------------------+-----------------------

Comment (by adamsilverstein):

 Replying to [comment:59 azaozz]:
 > Wondering if we can use the actual post lock instead of an option. By
 the time the revisions version update functions are called, the post is
 already locked to the user.
 >
 > `wp_check_post_lock()` would return false when checked for the current
 user but we can look at `get_post_meta( $post->ID, '_edit_lock', true )`
 for the lock "freshness" (regardless of the user) and prevent updating the
 revisions if the post was locked a few seconds ago.
 >
 > Edit: on second thought, that can miss if two requests come in at the
 exact same second, so probably not good enough.

 so, do you think the method used in the patch will work correctly?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16215#comment:60>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list