[wp-trac] [WordPress Trac] #23497: Revisions Rewrite using JS/Backbone
WordPress Trac
noreply at wordpress.org
Fri Mar 22 13:15:02 UTC 2013
#23497: Revisions Rewrite using JS/Backbone
---------------------------------------+------------------------
Reporter: adamsilverstein | Owner: westi
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 3.6
Component: Revisions | Version: 3.5.1
Severity: normal | Resolution:
Keywords: needs-patch needs-testing |
---------------------------------------+------------------------
Comment (by adamsilverstein):
Replying to [comment:120 ryan]:
> Another pluggable function? We've been trying to avoid adding new ones,
ever.
assume you are talking about the new 'wp_text_diff_with_count' function
that is just like wp_text_diff, but keeps track of changed lines while
calculating the diffs. i created a new function because i was worried
changing the original function would break something unexpectedly.
possible fixes:
* move the function elsewhere, so its not in in pluggable.php
* change the original function instead so no new function is added
which is the preferable correction? let me know and i will provide a
patch.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/23497#comment:121>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list