[wp-trac] [WordPress Trac] #23673: Add functions to generate metadata for video / audio

[WordPress Trac]

#23673: Add functions to generate metadata for video / audio
----------------------------+--------------------------
 Reporter:  wonderboymusic  |       Owner:  markjaquith
     Type:  enhancement     |      Status:  reopened
 Priority:  normal          |   Milestone:  3.6
Component:  Media           |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+--------------------------
Changes (by bpetty):

 * cc: bpetty (added)
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 All files included in this 3rd party library mention a readme.txt, but
 it's been stripped out of what is included with WP, and none of the files
 mention what this library is licensed under (I couldn't find it without
 hitting up the library's website).

 It is also interesting to note that this library is actually dual-licensed
 with GPL and a commercial license, thus it's really not quite compatible
 with the conditions WP is released under. For example, I could sell
 WordPress to someone (and what web designer doesn't sell a copy of WP to
 their clients technically?) without requiring anything beyond complying
 with the terms of the GPL, but with this library included, I would
 technically be required to purchase a commercial license from getID3 to do
 so.

 It should be clear to anyone looking at this code (as distributed from WP)
 what it's license and conditions are, and it should probably include both
 licenses with the library here.

 Also, I know this has been here for review for a while, but was there
 really not any way this could have been built in a more modular way so
 we're not including 20k lines of new PHP code just for this library (an
 additional 940KB for every WP install). For reference, that's about 6k
 more than every `WP_*` class currently included in WP, 4k more than
 SimplePie, and accounts for 15% of everything in `wp-includes`.

 This might only be used for maybe 10% to 15% of all installations, and
 even then, most users are only going to make use of the MP3 handler.
 They've have had plenty of ways of embedding audio and video into their
 site without needing any of this for a long time. I'm not saying it isn't
 useful, just that it's a lot to include in WP by default for something so
 far from the 80/20 rule.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23673#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software