[wp-trac] [WordPress Trac] #23697: Check and refresh post locks with heartbeat

[WordPress Trac]

#23697: Check and refresh post locks with heartbeat
-------------------------------------+------------------
 Reporter:  azaozz                   |       Owner:
     Type:  task (blessed)           |      Status:  new
 Priority:  normal                   |   Milestone:  3.6
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  autosave-redo has-patch  |
-------------------------------------+------------------

Comment (by azaozz):

 > [23733] introduced odd visual focus glitches... This item should get
 focus without a visible outline.

 Wasn't sure what is the proper way here, so left out the `outline: 0` for
 this commit.

 As far as I understand focus should always be visible for normally
 focusable elements, i.e. form elements and links. For elements that
 normally don't receive focus, the outline visibility depends on the
 function: if the element is used as a link or a control (i.e. has
 `onclick="some_action"`, etc.) the focus should be visible. If not, there
 is no need for the focus to be visible.

 This sounds good except when the focus is "invisible" there is one more
 "tabbing stop" that is undetectable for most users (thinking screen
 readers would read the focused element's text). In our case pressing tab
 would go to the first button, pressing shift+tab would go back to the <p>
 and if there is no outline, sighted users that don't use a mouse will be
 left wondering where the focus is.

 This can be avoided if we use `tabindex="-1"` (the element is focusable
 only with JS) but then screen reader users would not be able to go back to
 the text...

 The solution as I see it is to use `tabindex="-1"` and focus it while
 containing the tabbing inside the dialog:

 - When the dialog is opened, focus goes to the <p>.
 - Tabbing moves through the buttons.
 - When the next tab stop is outside the dialog, we move the focus to the
 <p> again.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23697#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software