[wp-trac] [WordPress Trac] #23497: Revisions Rewrite using JS/Backbone

[WordPress Trac]

#23497: Revisions Rewrite using JS/Backbone
---------------------------------------+------------------------
 Reporter:  adamsilverstein            |       Owner:  westi
     Type:  enhancement                |      Status:  reviewing
 Priority:  normal                     |   Milestone:  3.6
Component:  Revisions                  |     Version:  3.5.1
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch needs-testing  |
---------------------------------------+------------------------

Comment (by adamsilverstein):

 [attachment:23497.38.diff​ 23497.38.diff​] should fix the issue you
 discovered. the left handle had a default value of 0 that should have been
 1. now that i changed that, the compare two mode should load with 'first'
 on the left, not blank.

 please re-test! any more issues?


 Replying to [comment:113 MikeHansenMe]:
 > Initially when I load compare two mode the left side is (empty) and the
 right side has "third" after sliding the left slider to the center it
 shows "second" on the left and "third" on the right. When I slide the left
 handle back to the left it shows "first". So something is not loading
 correctly initially or maybe (empty) is correct and we are losing it after
 sliding.
 >
 > When switching back to single view after leaving the right handle on
 "second" in compare two mode. It retains the correct info. This seems to
 be working correctly now.
 >
 >
 > I think the first problem is a decision, do we include the empty one as
 the first or do we start on the "first" save. In single view the empty
 post always shows first. In compare two it shows initially but "first" is
 missing until you slide and "first" replaces empty.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23497#comment:116>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software