[wp-trac] [WordPress Trac] #23497: Revisions Rewrite using JS/Backbone

[WordPress Trac]

#23497: Revisions Rewrite using JS/Backbone
---------------------------------------+------------------------
 Reporter:  adamsilverstein            |       Owner:  westi
     Type:  enhancement                |      Status:  reviewing
 Priority:  normal                     |   Milestone:  3.6
Component:  Revisions                  |     Version:  3.5.1
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch needs-testing  |
---------------------------------------+------------------------

Comment (by adamsilverstein):

 mmmm - thought i had that fixed! the initial load is wrong because in the
 leftmost position it should show first, not blank. the 1st 'title only'
 revision should be ignored, so the 1st revision should show 'first' - as
 it does when you start dragging the left slider (in one handle mode you do
 see blank as removed in the left most compare position, thats what changed
 when you added your first revision).

 sounds like the initial load when you switched to compare two mode was
 off. i will try to reproduce and fix, does it matter what position the
 handle is in when you switch to two handled mode?

 glad to hear switching back to one handle mode works correctly now.

 i will fix the 1st issue and report back here, thanks for the tireless
 testing.

 Replying to [comment:113 MikeHansenMe]:
 > Initially when I load compare two mode the left side is (empty) and the
 right side has "third" after sliding the left slider to the center it
 shows "second" on the left and "third" on the right. When I slide the left
 handle back to the left it shows "first". So something is not loading
 correctly initially or maybe (empty) is correct and we are losing it after
 sliding.
 >
 > When switching back to single view after leaving the right handle on
 "second" in compare two mode. It retains the correct info. This seems to
 be working correctly now.
 >
 >
 > I think the first problem is a decision, do we include the empty one as
 the first or do we start on the "first" save. In single view the empty
 post always shows first. In compare two it shows initially but "first" is
 missing until you slide and "first" replaces empty.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23497#comment:114>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software