[wp-trac] [WordPress Trac] #23497: Revisions Rewrite using JS/Backbone

[WordPress Trac]

#23497: Revisions Rewrite using JS/Backbone
---------------------------------------+------------------------
 Reporter:  adamsilverstein            |       Owner:  westi
     Type:  enhancement                |      Status:  reviewing
 Priority:  normal                     |   Milestone:  3.6
Component:  Revisions                  |     Version:  3.5.1
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch needs-testing  |
---------------------------------------+------------------------

Comment (by MikeHansenMe):

 Replying to [comment:107 adamsilverstein]:
 > thanks again for the testing...
 >
 > on the 1st part sounds like the compare two mode is not loading
 correctly until you start sliding. i will try to reproduce that and see
 whats going on. i think i've seen that, will check. left side empty sounds
 like a revision with only title, eg the initial autosave; sounds like
 thats missing once you start dragging... maybe the wrong left handle model
 is being loaded. if you then drag the right hand (move it and stop to
 reload the left handle models), what happens when you drag the left again,
 does it show blank or 'first' in the 0 position?

 It shows (empty) initially then "first" after moving the slider back to
 the first location. So yes it seems to not be loading correctly initially.

 >
 > some of what you said in the second part makes me think you might be
 having a common confusion about the diff display. '''the display always
 shows what was removed on the left and what was added on the right.''' it
 is not showing one revision on each side! A merged mode where the removed
 added and unchanged lines are all in one column is implemented but
 currently hidden.

 Sorry bad wording on my part. I understand that it is one revision and
 shows what was removed/added. I would expect it to restore what is show on
 the right especially since the button is next to "To" however previously
 it restored the "From" side. This is now working correctly.


 >
 > also, to further clarify:
 >
 > in single handle mode the display shows what has "changed in this
 revision" - that is, what was added or removed since the previous
 revision.

 Initially it shows "first" on the left and "second" on the right which
 would be correct I replaced the text "first" with "second" after going to
 compare two mode and back it will show "second" on the right but nothing
 on the left when it should show "first" because that is what was removed
 when adding "second" same behavior on "third" as well.

 >
 > in compare two mode you are comparing 'whats changed between these two
 revisions'. dragging the left handle compares agains the right handle
 position, dragging the right handle compares agains the left handle
 position. compares are always newer agains older. clicking restore always
 restores the right handle position. (at least, thats the way its supposed
 to work!)
 >

 This does work now, as I mentioned before it previously did restore what
 was shown on the left even though the button was by "To".


 > with that in mind, do you still see the issues in part two?
 >
 > if you were confused about the diff display, thats only natural and
 demonstrates that the UI needs more explanatory text and visual cues that
 explain how it works.
 >

 The biggest problem I see currently (patch 36) is that after switching
 from compare two back to single mode those revisions are also out of
 place. Also the incorrect initial load of compare two.

 Let me know if that clarifies your questions. Sometimes I am not a clear
 as I try to be.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23497#comment:108>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software