[wp-trac] [WordPress Trac] #23497: Revisions Rewrite using JS/Backbone

[WordPress Trac]

#23497: Revisions Rewrite using JS/Backbone
---------------------------------------+------------------------
 Reporter:  adamsilverstein            |       Owner:  westi
     Type:  enhancement                |      Status:  reviewing
 Priority:  normal                     |   Milestone:  3.6
Component:  Revisions                  |     Version:  3.5.1
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch needs-testing  |
---------------------------------------+------------------------

Comment (by adamsilverstein):

 thanks again for the testing...

 on the 1st part sounds like the compare two mode is not loading correctly
 until you start sliding. i will try to reproduce that and see whats going
 on. i think i've seen that, will check. left side empty sounds like a
 revision with only title, eg the initial autosave; sounds like thats
 missing once you start dragging... maybe the wrong left handle model is
 being loaded. if you then drag the right hand (move it and stop to reload
 the left handle models), what happens when you drag the left again, does
 it show blank or 'first' in the 0 position?

 some of what you said in the second part makes me think you might be
 having a common confusion about the diff display. '''the display always
 shows what was removed on the left and what was added on the right.''' it
 is not showing one revision on each side! A merged mode where the removed
 added and unchanged lines are all in one column is implemented but
 currently hidden.

 also, to further clarify:

 in single handle mode the display shows what has "changed in this
 revision" - that is, what was added or removed since the previous
 revision.

 in compare two mode you are comparing 'whats changed between these two
 revisions'. dragging the left handle compares agains the right handle
 position, dragging the right handle compares agains the left handle
 position. compares are always newer agains older. clicking restore always
 restores the right handle position. (at least, thats the way its supposed
 to work!)

 with that in mind, do you still see the issues in part two?

 if you were confused about the diff display, thats only natural and
 demonstrates that the UI needs more explanatory text and visual cues that
 explain how it works.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23497#comment:107>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software